feat(arm): AzureDefenderOnSqlServersVMS - checks resource is a SQL with tier "Standard". #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def __init__(self): | ||
| name = "Ensure that Azure Defender is set to On for SQL servers on machines" | ||
| id = "CKV_AZURE_79" | ||
| supported_resources = ("Microsoft.Cache/Redis",) |
There was a problem hiding this comment.
Probably should be Microsoft.Security/pricings type and not Microsoft.Cache/Redis
|
|
||
| def scan_resource_conf(self, conf: Dict[str, Any]) -> CheckResult: | ||
| properties = conf.get("properties", {}) | ||
| resourceType = properties.get("resourceType") |
There was a problem hiding this comment.
I don't think there is resourceType in this resource, we can remove it.
There was a problem hiding this comment.
so how do we det to the "resourceType": "SqlServerVirtualMachines" to test it?
There was a problem hiding this comment.
we dont need it for ARM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
The function scan_resource_conf checks if a specific resource is a SQL Server with tier "Standard". If so, it returns a failure result; otherwise, it returns a success result.
Fix
The function checks if a resource is a SQL Server Virtual Machine with tier "Standard" and returns a pass or fail result accordingly.
Checklist: