feat(arm): add CKV_AZURE_173 to ensure that API management uses at least TLS 1.2 #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… APIManagementMinTLS12Check
|
|
||
| def scan_resource_conf(self, conf: dict[str, Any]) -> CheckResult: | ||
| properties = conf.get('properties', {}) | ||
| if 'security' in properties: |
There was a problem hiding this comment.
There is no field security in Microsoft.ApiManagement/service type
| properties = conf.get('properties', {}) | ||
| if 'enableClientCertificate' in properties: | ||
| enableClientCertificate = properties['enableClientCertificate'] | ||
| if 'enableFrontendTls10' in enableClientCertificate: |
There was a problem hiding this comment.
enableClientCertificate is a bool value.
identity
identity
identity
goldyBH
changed the title
|
What do I need to do to fix the security? |
| properties = conf.get('properties', {}) | ||
| if 'identity' in properties: | ||
| identity = properties['identity'] | ||
| if 'enableFrontendTls10' in identity: |
There was a problem hiding this comment.
this is the identity structure -
"identity": {
"type": "string",
"userAssignedIdentities": {
"{customized property}": {
"clientId": "string",
"principalId": "string"
}
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIManagementMinTLS12
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supersedes any of the types
- feat: to indicate new features or checks
- fix: to indicate a bugfix or handling of edge cases of existing checks
- docs: to indicate an update to our documentation
- chore: to indicate adjustments to workflow files or dependency updates
- platform: to indicate a change needed for the platform
Additionally a scope is needs to be added to the prefix, which indicates the targeted framework, in doubt choose 'general'.
Description
ensure that API management uses at least TLS 1.2
Checklist: