feat(arm): ACRGeoreplicated #6324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
ChanochShayner
requested changes
May 19, 2024
|
|
||
| name = "Ensure geo-replicated container registries to match multi-region container deployments." | ||
| id = "CKV_AZURE_165" | ||
| supported_resources = ("Microsoft.ContainerRegistry/registries",) |
There was a problem hiding this comment.
Looks like u should scan the Microsoft.ContainerRegistry/registries/replications resource and look for the location field.
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
||
| def scan_resource_conf(self, conf: dict[str, list[Any]]) -> CheckResult: | ||
| sku = conf.get("sku") |
There was a problem hiding this comment.
There was a problem hiding this comment.
Please check it
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
SaraWeinberg1234
requested a deployment
to
scan-security
GitHub Actions
Waiting
ChanochShayner
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
adds a ACRGeoreplicated
Description
Checks whether a certain field exists and contains a specific value.
If so, checks whether there is also a certain field that contains true
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: