feat(arm): ACREnableZoneRedundancy #6326
Conversation
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
| return CheckResult.FAILED | ||
|
|
||
| # check each replica. default=false | ||
| replications = conf.get("replications", {}) |
There was a problem hiding this comment.
I don't see the replications field in Microsoft.ContainerRegistry/registries/replications or Microsoft.ContainerRegistry/registries, are you sure this is the field we should check here?
There was a problem hiding this comment.
I changed the error
can you confirm me please
There was a problem hiding this comment.
My comment was for the resource template, Are you sure that those resources have the field replications to configure?
There was a problem hiding this comment.
I checked and I think it's good now
There was a problem hiding this comment.
You are looking for the field replications in the Microsoft.ContainerRegistry/registries resource type
but I don't see here the replications filed
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
changed the title
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
|
I changed the mistakes |
| # check registry. default=false | ||
| properties = conf.get("properties") | ||
| if properties and isinstance(properties, dict): | ||
| if properties.get("zoneRedundancy", []) != [True]: |
There was a problem hiding this comment.
zoneRedundancy should be Enabled or Disabled and not a boolean value
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
…REnableZoneRedundancy
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
requested a deployment
to
scan-security
GitHub Actions
Waiting
channy-katz
changed the title
| # check registry. default=false | ||
| properties = conf.get("properties") | ||
| if properties and isinstance(properties, dict): | ||
| if properties.get("zoneRedundancy") == "disabled": |
There was a problem hiding this comment.
| if properties.get("zoneRedundancy") == "disabled": | |
| if properties.get("zoneRedundancy") == "Disabled": |
| "properties": { | ||
| "adminUserEnabled": "[parameters('acrAdminUserEnabled')]", | ||
| "zoneRedundancy": | ||
| "disabled" |
There was a problem hiding this comment.
| "disabled" | |
| "Disabled" |
| "[resourceId('Microsoft.ContainerRegistry/registries/', parameters('acrName'))]" | ||
| ], | ||
| "properties": { | ||
| "zoneRedundancy": "disabled" |
There was a problem hiding this comment.
| "zoneRedundancy": "disabled" | |
| "zoneRedundancy": "Disabled" |
| }, | ||
| "properties": { | ||
| "adminUserEnabled": "[parameters('acrAdminUserEnabled')]", | ||
| "zoneRedundancy": "enabled" |
There was a problem hiding this comment.
| "zoneRedundancy": "enabled" | |
| "zoneRedundancy": "Enabled" |
| "[resourceId('Microsoft.ContainerRegistry/registries/', parameters('acrName'))]" | ||
| ], | ||
| "properties": { | ||
| "zoneRedundancy": "enabled" |
There was a problem hiding this comment.
| "zoneRedundancy": "enabled" | |
| "zoneRedundancy": "Enabled" |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
adds a ACREnableZoneRedundancy
Description
The function checks whether the "zoneRedundancy" property is set to True for a resource and all its replications. If any "zoneRedundancy" is not True, it returns a failure result; otherwise, it returns a pass result.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: