Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets): eliminate false positives in entropy keyword combinator detector #6327

Merged
merged 8 commits into from
May 22, 2024

Conversation

tronxd
Copy link
Contributor

@tronxd tronxd commented May 19, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

support filtering false positives for suspected base64 high entropy strings

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tronxd tronxd changed the title feat(secrets): feat(secrets): eliminate false positives in entropy keyword combinator detector May 19, 2024
@pazbechor pazbechor self-requested a review May 19, 2024 14:07
@tronxd tronxd merged commit 368cd12 into main May 22, 2024
41 checks passed
@tronxd tronxd deleted the base64_fp_reduction branch May 22, 2024 06:44
shoshiGit pushed a commit to shoshiGit/shoshi-wolpe-checkov that referenced this pull request May 22, 2024
…r detector (bridgecrewio#6327)

* support filtering false positives for suspected base64 high entropy strings

* UT

* lint

* fix UT

* use custom regex

* fix UT

* fix UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants