Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with specific option combination. #1927

Merged
merged 1 commit into from
May 20, 2024

Conversation

fernape
Copy link
Contributor

@fernape fernape commented May 19, 2024

With some option combination the code to be compiled has not been updated with regards to the changes in conky::rec, i.e get_height() becomes height() and get_width() becomes width().

Related to 1918

Checklist

  • [X ] I have described the changes
  • [ X] I have linked to any relevant GitHub issues, if applicable
  • [X ] Documentation in doc/ has been updated
  • [ X] All new code is licensed under GPLv3

Description

  • Describe the changes, why they were necessary, etc
  • Describe how the changes will affect existing behaviour.
  • Describe how you tested and validated your changes.
  • Include any relevant screenshots/evidence demonstrating that the changes work and have been tested.

With some option combination the code to be compiled has not been updated with
regards to the changes in conky::rec, i.e get_height() becomes height() and
get_width() becomes width().
@github-actions github-actions bot added sources PR modifies project sources display: x11 Issue related to X11 backend labels May 19, 2024
Copy link

netlify bot commented May 19, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 88e5e5f
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/664a3ff74cfe090007932b03

@brndnmtthws brndnmtthws merged commit 682db0c into brndnmtthws:main May 20, 2024
62 of 63 checks passed
@brndnmtthws brndnmtthws added the bug Bug report or bug fix PR label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR display: x11 Issue related to X11 backend sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants