Payments Report: Add POS data columns

[dennisreimann]

Extends the payments report data with subtotal, tip and discount amounts. This works for keypad and cart sales. Closes #5290.

[dstrukt]

If I understand the scope of the PR, functional tACK!

[Kukks]

I don't know how I feel about this, it's so specific to the POS that it would be a shame to pollute such a wide-scoped report. I would see if if is possible to create a dedicated report that extends this one.

[dstrukt]

I don't know how I feel about this, it's so specific to the POS that it would be a shame to pollute such a wide-scoped report. I would see if if is possible to create a dedicated report that extends this one.

That's valid. Makes future plug-in (tip splitting, podcast splits, whatever other stuff people come up, etc...) more easily extensible, but can also see the case for simply including the core POS data breakdown here as well.

[pavlenex]

I don't know how I feel about this, it's so specific to the POS that it would be a shame to pollute such a wide-scoped report. I would see if if is possible to create a dedicated report that extends this one.

So you're suggesting we have a dedicated app report or a pos report where we could display data for the POS app in particular? I agree with you on that one if so, thinking about refund report we want to have, this probably shouldn't be in the main one as it's quite app-specific from what I understood.

[NicolasDorier]

I believe that we should allow the ability to add or remove columns in the report page.
The backend just fetch all the data, and the front end hide/show columns based on user's preferences.

That way, we can add lot's of missing column which may be app specific, but this isn't a problem.

If we agree that we can customize which columns to hide or show, we should merge that first as it is ready, and maybe book the column selection for next major.

[pavlenex]

@NicolasDorier Could we display all data including refunds & tips with that approach? I think that's quite sensible idea for this problem, and would allow people to customize things, we're getting a lot of complaints in general that people aren't getting info they used to from the reporting, I am still working on their specific feedback.

[dstrukt]

cACK to showing/hiding columns as per @NicolasDorier's suggestions, seems like an elegant approach to customizing the view for each use case

cc @dennisreimann are we in a position to do this with tables? imagine it'll just be an additional bootstrap column with some kind of + button with a dropdown of potential items to add - conceptually it seems like it might work 🤷