Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeConnector improvements and support for Coroutines #676

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

NodeConnector improvements and support for Coroutines #676

wants to merge 4 commits into from

Conversation

mapm14
Copy link
Contributor

@mapm14 mapm14 commented Feb 5, 2024 •
edited

Description

  • Current NodeConnectors were not caching Inputs sent before onCreate invocation as they were doing with Outputs, this PR solves this problem
  • Added new module for Coroutines support

Checklist

  • I've updated CHANGELOG.md if required.
  • I've updated the documentation if required.
  • Add Coroutines unit tests if draft version is approved.

@mapm14 mapm14 added enhancement New feature or request api-breaking labels Feb 5, 2024
@mapm14 mapm14 added this to the 2.0 milestone Feb 5, 2024
@mapm14 mapm14 requested a review from zsoltk February 5, 2024 14:07
@mapm14 mapm14 self-assigned this Feb 5, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 7, 2024
View reviewed changes
appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/Node.kt
import com.bumble.appyx.navigation.plugin.NodeReadyObserver
import com.bumble.appyx.navigation.plugin.UpNavigationHandler
import com.bumble.appyx.navigation.plugin.plugins
import com.bumble.appyx.navigation.plugin.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

com.bumble.appyx.navigation.plugin.* is a wildcard import. Replace it with fully qualified imports.
@zsoltk zsoltk modified the milestones: 2.0, 2.1 Feb 12, 2024
@mapm14 mapm14 marked this pull request as ready for review February 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsoltk zsoltk Awaiting requested review from zsoltk

Assignees

@mapm14 mapm14

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mapm14 @zsoltk