Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll to time after clicking a date on mobile #15123

Closed
wants to merge 1 commit into from
Closed

fix: scroll to time after clicking a date on mobile #15123

wants to merge 1 commit into from
+7 −1

Conversation

vikrant845
Copy link
Contributor

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  1. Open an event in mobile view.
  2. Select a date.
  3. You should be automatically scrolled to the timeslots section.

Checklist

  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented May 20, 2024

@borawakevikrant is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team May 20, 2024 10:23
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🧹 Improvements Improvements to existing features. Mostly UX/UI labels May 20, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label May 20, 2024
@dosubot dosubot bot added this to the v4.2 milestone May 20, 2024
@vikrant845 vikrant845 changed the title re-add: scroll to time after clicking a date on mobile fix: scroll to time after clicking a date on mobile May 20, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 20, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Udit-takkar
Udit-takkar reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vikrant845, Thanks for contributing but the issue has been fixed here #15124

@dosubot dosubot bot modified the milestone: v4.2 May 20, 2024
@vikrant845 vikrant845 deleted the re-add/scroll-to-time branch May 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3764] re-add: scroll to time after clicking a date on mobile
3 participants
@vikrant845 @Udit-takkar @borawakevikrant