Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help honest clients-send all blames including last one to banned player #73

Merged

Conversation

emergent-reasons
Copy link
Collaborator

Fixes #72

I don't see anywhere that PlayerCount() or other logic will be impacted by leaving the blamed player in the pool. For example we use firstBan to track the voting status explicitly - so the banned player still sitting in the pool should not cause a problem.

The worst case I can think of is that the banned player is malicious and spamming but I think that would be better to solve directly with a more strict specification that that lets the server and clients immediately identify a misbehaving client.

@alwaysAn0n thanks for the discussion leading to this.

@zquestz zquestz merged commit 4515ba1 into cashshuffle:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants