help honest clients-send all blames including last one to banned player #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
I don't see anywhere that
PlayerCount()
or other logic will be impacted by leaving the blamed player in the pool. For example we usefirstBan
to track the voting status explicitly - so the banned player still sitting in the pool should not cause a problem.The worst case I can think of is that the banned player is malicious and spamming but I think that would be better to solve directly with a more strict specification that that lets the server and clients immediately identify a misbehaving client.
@alwaysAn0n thanks for the discussion leading to this.