Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPCs actually give items when asked #3359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 4, 2023

Summary

SUMMARY: Bugfixes "NPCs actaully give items when asked"

Purpose of change

Describe the solution

  • removed checks for debt entirely, as the player already passed the check.
  • TALK_SHARE_EQUIPMENT was wrongly checking infected, fixed it to use asked_for_item instead.
  • as that blocks repeated asking for items, added another dialogue option (with higher difficulty)
  • made denying less rude, because that causes even friendly npc to swear at you

Describe alternatives you've considered

migrate entire dialogue system to Lua

Testing

2023-10-04_21-47-45.mp4

Additional context

@github-actions github-actions bot added src PR changes related to source code. data PRs related to datas. Won't crash game (probably) labels Oct 4, 2023
@chaosvolt
Copy link
Member

Errors seem unrelated, far as I can tell?

@olanti-p
Copy link
Member

olanti-p commented Oct 5, 2023

There's some weird behavior with persuasion chances.

  1. Spawn random NPC
  2. Ask to do something for them
  3. Accept mission
  4. Ask for equipment
  5. Choose "Well, I'm helping you out..." with 100% chance
  6. Get equipment
  7. Ask for more equipment
  8. Persuasion check shows 100%
  9. NPC agrees and gives something
  10. Goto step 7
  11. Eventually NPC gives away all their inventory and has nothing to give anymore.

@olanti-p olanti-p changed the title fix: NPCs actaully give items when asked fix: NPCs actually give items when asked Oct 5, 2023
@scarf005
Copy link
Member Author

scarf005 commented Oct 7, 2023

not sure why but persuation seems to be bugged atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) src PR changes related to source code.
Projects
None yet
3 participants