New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): round ~1 pound to 400g, 500g #4568
base: main
Are you sure you want to change the base?
Conversation
eradicate 'they weigh about a pound (453g)' and replace it with 500g
@@ -313,7 +313,7 @@ | |||
"material": "powder", | |||
"volume": "125ml", | |||
"charges": 400, | |||
"//2": "Previously 10 doses to a gram, so about 400 to the pound.", | |||
"//2": "Previously 10 doses to a gram, so about 400g to the 500g.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
400 grams to the 500 grams? Just delete this comment if it's not going to be actually useful anymore.
@@ -27,8 +27,8 @@ | |||
"repairs_like": "gauntlets_larmor", | |||
"type": "ARMOR", | |||
"name": { "str": "pair of boxing gloves", "str_pl": "pairs of boxing gloves" }, | |||
"description": "A pair of big, red, 8 oz. boxing gloves. They make dexterous tasks near impossible, but provide ample protection.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IRL, boxing gloves are standardized by weight. As such, this isn't actually a case of them just slapping a weight of roughly a pound on it, but legitimately what a pair of fairly-standard boxing gloves would weigh.
Not saying it shouldn't be changed, just clarifying that this isn't a case of them just choosing to make them about a pound arbitrarily.
@@ -118,7 +118,7 @@ | |||
"copy-from": "ruger_lcr_38", | |||
"type": "GUN", | |||
"name": { "str_sp": "Ruger LCR .22" }, | |||
"weight": "420 g", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little out of place for this PR, given that a Ruger LCR .22 is legitimately about 420 grams IRL (422.4 to be exact). Considering this PR is stated to be primarily about handling cases where something was set to be about a pound for the sake of just making it "somewhat heavy", I'd hesitate to say this really fits. 420 is already a perfectly round number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, tho i was thinking of #2505
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, though I think that nearest 10 grams is already within #2505 's goal. 100% would support rounding the Cobray Streetsweeper to 420g, for example. (And magazines I have no qualms over how you adjust them, those are a lot more variable anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. will revert it when i get home.
@@ -564,7 +564,7 @@ | |||
"flags": [ "DROP_ACTION_ONLY_IF_LIQUID" ], | |||
"description": "Sulfuric acid: viscous, foul-smelling and extremely corrosive, particularly to organic matter and evil clowns. Although used to prepare a number of chemicals, it is mostly known as battery acid, due to its widest commercial application.", | |||
"volume": "250 ml", | |||
"weight": "460 g", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
460 is actually about the correct weight for 250 ml of sulfuric acid (the calculated weight based on density being 457.5)
Looks to me like a couple chemicals and firearms got caught in the crossfire when in actuality they've got pretty accurate weights that are still nice rounded numbers regardless (Also, in hindsight I totally should have just done a single review, but I initially came in only expecting comment on one thing before it turned into 3 haha) |
While not in the 500 but rather in the 1500 range, books need some help as well. {
"type": "BOOK",
"name": {
"str": "Internal Combustion Fundamentals",
"str_pl": "copies of Internal Combustion Fundamentals"
},
"description": "A college-level textbook that details the operation, maintenance, and repair of internal combustion engines.",
"bashing": 4,
"material": [
"paper"
],
"symbol": "?",
"looks_like": "story_book",
"color": "blue",
"flags": [
"TINDER",
"FLAMMABLE"
],
"id": "book_icef",
"copy-from": "base_book",
"weight": "1587 g",
"volume": "1500 ml",
"price": "5950 cent",
"price_postapoc": "2250 cent",
"skill": "mechanics",
"required_level": 4,
"max_level": 8,
"intelligence": 6,
"time": "30 m",
"fun": -1
} |
Purpose of change
metricate item weights, part 1.
Describe the solution
replaced all items weighting 450 ~ 500g to 500g, and items weighting 400 ~ 450 to 400g.
Describe alternatives you've considered
making them all 500g to be nice and simple.
Testing
passed automated tests in local environment.
Additional context
~98.4% of existing countries have fully adopted metric system (192/195 countries, with the exception of Liberia, Myanmar, and the United States.)