Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM keyboard layout selector #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

florian-krueger
Copy link

There is a new menu entry "VM key layout" (can this be hidden for enhanced mode?). To make this work I needed to extend the network interaction for keyboard actions to include on each key hit the currently configured layout. I changed the separater from "-" to "_". So each keyboard event looks like "145_1_en-us".

Issues:

  • Not sure if it is great to have another entry in the main menu
  • The keyboard mappings are now in front-end for the text typing function. So we have two mappings: char to KeyCode per keyboard layout and KeyCode to ScanCode per keyboard layout. Could this be unified somewhere?
  • When connecting to a VM, is there any chance to find out the input layout in the VM? Another option would be to store the chosen layout in cookies so it stays the same after reconnect - maybe per VM ID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant