-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Time Drift Calculation #8236
base: main
Are you sure you want to change the base?
Conversation
updates: - [github.com/asottile/pyupgrade: v3.3.1 → v3.3.2](asottile/pyupgrade@v3.3.1...v3.3.2)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8236 +/- ##
==========================================
+ Coverage 85.08% 87.08% +1.99%
==========================================
Files 148 148
Lines 18455 18470 +15
Branches 2428 2525 +97
==========================================
+ Hits 15703 16085 +382
+ Misses 2475 2106 -369
- Partials 277 279 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@auvipy Still working on resolving some things here, but will ping you once it's ready. |
I still can't see any fix except the introduction of a newly introduced variable |
@auvipy Not totally done (also need to add test coverage), but the idea is that
We use this new variable in the drift calculation to avoid the issues mentioned here: #8207 |
@auvipy Basic implementation is done, let me know if what I said makes sense. Will add unit tests tomorrow if you think it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were you able to fix it?
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fix bug discussed in #8207 but doing the time drift calculation in events in UTC as opposed to local times.