-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsyshid: Emulate Skylander Portal #971
base: main
Are you sure you want to change the base?
Conversation
68e7612
to
051c149
Compare
051c149
to
ee60705
Compare
Is this still being worked on or is it ready for review? Asking because some suggestions by @ssievert42 are still open or without comment. |
Yes sorry, just been busy with work, will fix those comments this week hopefully |
2094b2c
to
b547c5a
Compare
Just pushed up some changes, but still haven't implemented the find device across backends method, so will aim to do that before the end of the week. |
b547c5a
to
3cde4d8
Compare
3cde4d8
to
3ebadc0
Compare
All those requested changes have now been made, let me know if that's what you had anticipated it looking like @ssievert42 Otherwise, I am not convinced with the performance on the Vicarious Visions games (Swap Force and Superchargers), I've had varying degrees of success because at some point the game decides to stop sending commands to the portal, presumably because the emulated portal has replied too fast or too slow. Will keep investigating the perfect timing. |
Had a playthrough of Swap Force and 10s might be the sweet spot for now, could be something that I can add as a custom option so that users can increase/decrease themselves to try to avoid the same issues that occur with a real portal, but for now the PR is good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Just some minor nitpicks :)
About the timing issues: These kinds of problems tend to make me really nervous 😅. Do you think subtracting the time it takes to run the other stuff in Read
and SetReport
from the time that should be slept before we can return might help?
Otherwise a dirty workaround might be to add a button to detach and reattach the emulated portal ¯\_(ツ)_/¯
3ebadc0
to
cfbbbbb
Compare
@ssievert42 more review work added - unfortunately without a proper core timing module there isn't much we can do besides sleep the thread for a bit, I have the done the same work on Dolphin and that framework (schedule the transfer to be completed at x amount of thread ticks rather than time based), but would need a major rework to Cemu's core. Even detaching/reattaching doesn't fix the issue, the game just decides to stop sending commands to the portal, go figure |
Welp, that's certainly a nice thing to do of the game. LGTM 👍 |
Hello, I just did some testing with Skylanders Giants. Cemu consistently crashes, either when the Activision logo is about to stop spinning, at various random points at the middle and end of the Vicarious Visions logo, or (my most successful attempt) a crash on "Press A". Just for kicks I tested with vanilla Cemu and it booted all the way through. |
@ElBread3 thanks for helping test, I don't have giants for the Wii U so can't confirm that but will see if I can get someone else to recreate the bug so I can try to fix it locally. I would have thought trap team would have the same issue but I guess not! |
cfbbbbb
to
ae49055
Compare
Tested with a debug executable today and did not crash, though loading takes too long to daily drive, of course. Planning on testing with Disney Infinity on your infinitybase branch later once I buy it |
I ended up grabbing giants and I had no crashes - might be Windows only so I will try to build on a Windows machine to see if I can replicate. Have you tried any other Skylander games @ElBread3? |
ae49055
to
d58495d
Compare
I have found that the crash happens when fmt::print is called, something that I still don't really understand but the error message is "Stack cookie instrumentation code detected a stack-trace buffer overrun." I have commented this out for now, but @ssievert42 if you could confirm if this is actually doing something valuable besides just being a debug statement let me know! |
d58495d
to
675573b
Compare
Just made the layout of the window look a bit nicer and even |
OK I tested the print fix and Giants booted and is playable. To answer if I have other Skylanders games I also own Imaginators and Superchargers; The only other game that crashed when I did my first tests was Superchargers, crashing on the logo appearing, but it booted after a handful of attempts and still boots consistently. And Imaginators works fine. |
@deReeperJosh That call to |
675573b
to
81fd07a
Compare
We had some chat about it in https://discord.com/channels/286429969104764928/1017917335874572308/1155847973863964702 if removing it is ideal, then go ahead and i'll close the other pr, the logged error was basically "Bad file descriptor" while writing to fmt:: though. |
@deReeperJosh Just wondering do you plan to make a Lego Dimensions toy pad emulator for Cemu since you've already worked on Skylanders and Disney Infinity? |
@ElBread3 haven't ever actually played lego dimensions, but if someone has done some documentation on the USB protocols for it I can try to pick it up :) |
81fd07a
to
858a648
Compare
@deReeperJosh Have you looked at the Disney Infinity Emulation yet? |
@ETE-Design yes, I have a branch on my repo where the portal is recognised (no character loading yet) but I don't have a Wii U and games to test with any more, so I can't get past the EULA Error screen |
@deReeperJosh I've had to modify the code to load the Disney Infinity base and dump sys, but I've gotten past the error. However I can't test the characters cause the game doesn't render. Do you guys want me to record the boot up with debug overlay and put it here? If so, should I record it with Vulkan or OpenGL or both? |
skylanders renders just fine on current code though..... |
@Squall-Leonhart I was referring to Disney Infinity. An interesting note is that Disney Infinity seems to have nearly the same issue with rendering as Cars 3: Driven To Win, also developed by the same studio and therefore probably runs on the same engine. But yes, the Skylanders games work great |
858a648
to
1da2915
Compare
Not sure if there is much more left on this PR but I have become largely too busy to be able to continue working on fun side projects such as this - I will keep this PR open and continue to update with commits to main when I get the chance but won't be able to pay as much attention to it as previously |
@deReeperJosh Thanks for your work on this, I'm almost done playing Skylanders Giants on your fork, and it has worked very well so far. I plan on playing the following 4 entries as well, so I'll let you know about any instability or other issues. Don't worry about fixing anything until/unless you have time for it; I totally understand life getting in the way of hobbies and side projects. |
1da2915
to
bd030a2
Compare
bd030a2
to
2665033
Compare
@deReeperJosh I have an Wii U + Disney Infinity - Anything I can help with to get Disney Infinity working on CEMU? |
2665033
to
db937b7
Compare
@ETE-Design I have a branch on my repo where I have my infinity base progress, there isn't much there yet (no loading/removing figures or anything) but it would be good if you could test getting in game, you need to dump the erreula from your console iirc to get past the menu |
The portal audio is underflowing, leading to the issue reported in #1146 |
db937b7
to
cf225c0
Compare
@Squall-Leonhart that is mostly an issue with the Windows HID transfers, afaik libusb doesn't have the same problem, would be ideal if windows users also had the option to use libusb in the future |
Quite possibly, i can't recall what the barrier for using it on windows is, but building with -DENABLE_NSYSHID_WINDOWS_HID=OFF hasn't demonstrated any odd behaviors in lego dimensions to date, alas i don't have skylanders to verify if the portal sounds work better with it. |
Changing the flag is not enough. Last time I tried, libusb via vcpkg had issues linking on Windows. It's probably solvable but then more work needs to be done so we can support windows HID API + libusb devices in parallel. At any rate this topic is outside the scope of this PR so lets not further clutter it. |
cf225c0
to
52a0311
Compare
52a0311
to
c8cffb1
Compare
c8cffb1
to
8e81439
Compare
Carrying on from some of the work I have done on Dolphin and RPCS3, and thanks to #950 being merged, I am opening this PR up with the ability to emulate the Skylander Portal on Cemu.
Currently have tested Trap Team and Swap Force as working on my Mac, but hoping to get feedback and some testers on this PR too. Hoping to add Disney Infinity in the near future, but I don't currently have access to my Wii U so can't dump the necessary erreula to test my changes have actually worked there.
Would partly close #588