proposal: push to multiple registries #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
cert-manager-prow
bot
added
release-note-none
hawksight
reviewed
May 17, 2024
wallrj
approved these changes
May 31, 2024
There was a problem hiding this comment.
/lgtm
I'd like to see the images pushed to three places:
- quay.io/jetstack (for backwards compatibility)
- quay.io/cert-manager ( to "reinforce the independence and neutrality of the cert-manager project")
- ghcr.io/cert-manager (for resilience if quay.io is down)
I looked for any comparison of the availability of quay.io vs ghcr.io, but couldn't find anything.
Anecdotally I've heard a few people say that ghcr.io has fewer outages, but it'd be nice to find some hard evidence of that before directing users to use one or the other registry.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
Proposal for pushing to an additional, non "jetstack" branded container registry.
Kind
proposal
Release Note