Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing coverage changes #2222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kuhnroyal
Copy link
Member

@kuhnroyal kuhnroyal commented May 19, 2024

Testing coverage - DO NOT MERGE!

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal self-assigned this May 19, 2024
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
dio/lib/src/adapters/browser_adapter.dart 🟠 75% 🟠 68.92% 🔴 -6.08%
dio/lib/src/cancel_token.dart 🟢 83.33% 🟠 75% 🔴 -8.33%
dio/lib/src/dio/dio_for_browser.dart 🟠 57.14% 🟢 100% 🟢 42.86%
dio/lib/src/dio/dio_for_native.dart 🟢 91.3% 🔴 5.8% 🔴 -85.5%
dio/lib/src/dio_mixin.dart 🟢 93.81% 🟢 90.27% 🔴 -3.54%
dio/lib/src/headers.dart 🟢 95.12% 🟢 92.68% 🔴 -2.44%
dio/lib/src/response.dart 🟠 55.56% 🔴 33.33% 🔴 -22.23%
plugins/http2_adapter/lib/src/connection_manager_imp.dart 🟠 60.47% 🟢 75.97% 🟢 15.5%
Overall Coverage 🟢 80.58% 🟢 78.51% 🔴 -2.07%

Minimum allowed coverage is 0%, this run produced 78.51%

@kuhnroyal
Copy link
Member Author

@cfug/devs The dio_for_browser and connection_manager_imp diff is wrong, everything else looks reasonable. I am sure there is something off, caused by merging the coverage files. I will get on this after my vacation.

For now just take this as a rough indication :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant