Add several new GUI packages and their dependencies #8390
Conversation
| description 'Discord is a proprietary, cross-platform, all-in-one voice and text chat application.' | ||
| homepage 'https://discord.com/' | ||
| version '0.0.27' | ||
| license 'Proprietary' |
There was a problem hiding this comment.
Is this the true license?
There was a problem hiding this comment.
I am not sure about it. Snap said it is License: Proprietary and Arch said License: custom
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/discord" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Why not use a relative path for clarity?
There was a problem hiding this comment.
Do you mean using relative path as target in symlinks?
There was a problem hiding this comment.
Something like ./relative/path.
There was a problem hiding this comment.
Relative path will not work with different directories, like ../share/discord will not work in /usr/local/share/applications
There was a problem hiding this comment.
How about an absolute path then? Something like #{CREW_PREFIX}/path/to/file?
| # https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=eclipse-cpp | ||
| require 'package' | ||
|
|
||
| class Eclipse_cpp < Package |
There was a problem hiding this comment.
I see what you're trying to do here. Why not create an Eclipse.rb which allows the user to select which Eclipse version they would like to install like we do with the php and jdk packages? That leads to another question. Can these packages be installed concurrently or do they create a conflict with each other? In the latter case, would it make sense to add logic to prevent installing the others to avoid conflicts? EDIT: I see that logic already exists. Nice!
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/slack" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Use relative path for clarity?
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/eclipse" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Use relative path for clarity?
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/eclipse" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Use relative path for clarity?
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/eclipse" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Use relative path for clarity?
|
|
||
| def self.install | ||
| prefix = "#{CREW_DEST_PREFIX}/share/code" | ||
| symlink_prefix = prefix.delete_prefix(CREW_DEST_DIR) |
There was a problem hiding this comment.
Use relative path for clarity?
There was a problem hiding this comment.
See my comment above
There was a problem hiding this comment.
These are nice additions @supechicken! Can we add entries to tools/packages.yaml and include the manifest filelists?
| # handle icons | ||
| %w[16 22 24 32 48 64 128 256 512 1024].each do |size| | ||
| FileUtils.mkdir_p "#{icon_prefix}/#{size}x#{size}/apps" | ||
| FileUtils.cp Dir["plugins/org.eclipse.platform_#{version}*/eclipse#{size}.png"], "#{icon_prefix}/#{size}x#{size}/apps/eclipse.png" |
There was a problem hiding this comment.
Shouldn't the destination be a directory instead of a file?
|
It's been 3 months since this has seen any activity. Any update @supechicken? |
| require 'package' | ||
|
|
||
| class Eclipse_php < Package | ||
| description 'Highly extensible IDE (C/C++ version)' |
Putting all of them into one PR as it is easier for me to work on it.
New packages and test status
Packages that need binaries
Run the following to get this pull request's changes locally for testing.