-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNI: Update skel.PluginMain to skel.PluginMainFunc for cni 1.2.0 #32618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @squeed mind taking a quick look as well?
/test |
Commit dd01ba7 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commits dd01ba7, 7b5af3b do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Deprecated: Use github.com/containernetworking/cni/pkg/skel.PluginMainFuncs instead. https://github.com/containernetworking/cni/blob/c04330ee9e0bb932e1e3eda757813e2f212e746b/pkg/skel/skel.go#L431C1-L432C1 Upstream release: https://github.com/containernetworking/cni/releases/tag/v1.2.0 Signed-off-by: scyda <scyda@outlook.com>
CNI: Update skel.PluginMain to skel.PluginMainFunc
Deprecated: Use github.com/containernetworking/cni/pkg/skel.PluginMainFuncs instead.
https://github.com/containernetworking/cni/blob/c04330ee9e0bb932e1e3eda757813e2f212e746b/pkg/skel/skel.go#L431C1-L432C1
Upstream release: https://github.com/containernetworking/cni/releases/tag/v1.2.0