endpointmanager: Skip warning logs for endpoints being removed #32619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers of endpoint functions should not need to care if the function failed due to lockAlive() or rlockAlive() finding the endpoint in the state of being deleted. Use ErrNotAlive for both cases. This simplifies the call sites testing for this error condition. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Skip warning log for failed policy update for endpoints that are being removed.
This avoids unnecessary warnings (and CI flakes) like:
Found 1 k8s-app=cilium logs matching list of errors that must be investigated:
2024-05-19T16:15:52.160976650Z time="2024-05-19T16:15:52Z" level=warning msg="Failed to apply policy map changes. These will be re-applied in future updates." ciliumEndpointName=kube-system/coredns-7db6d8ff4d-t6sjv containerID=7120688df8 containerInterface= datapathPolicyRevision=1 desiredPolicyRevision=1 endpointID=370 error="lock failed: endpoint is in the process of being removed" identity=42104 ipv4=10.0.0.46 ipv6="fd02::a8" k8sPodName=kube-system/coredns-7db6d8ff4d-t6sjv subsys=endpointmanager
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
release-note/misc
|
/test |
tommyp1ckles
approved these changes
May 20, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip warning log for failed policy update for endpoints that are being removed.
This avoids unnecessary warnings (and CI flakes) like: