Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish TODO: handle error #215

Closed
wants to merge 2 commits into from
Closed

Finish TODO: handle error #215

wants to merge 2 commits into from

Conversation

cospectrum
Copy link
Contributor

No description provided.

@eaufavor eaufavor added the enhancement New feature or request label May 1, 2024
@johnhurt johnhurt added the Accepted This change is accepted by us and merged to our internal repo label May 24, 2024
@johnhurt
Copy link
Contributor

Nice, I'm accepting this. We'll merge it internally and it will show up in the public main branch in a few days/weeks (attributed to you) when we do our next sync. Thanks!

eaufavor pushed a commit that referenced this pull request May 31, 2024
@cospectrum @johnhurt
finish todo
940f46c 
---
reafactor

Includes-commit: 41ca473
Includes-commit: f5870a9
Replicated-from: #215
eaufavor pushed a commit that referenced this pull request May 31, 2024
@cospectrum @eaufavor
finish todo
d412311 
---
reafactor

Includes-commit: 41ca473
Includes-commit: f5870a9
Replicated-from: #215
@drcaramelsyrup
Copy link
Contributor

Merged in d412311. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accepted This change is accepted by us and merged to our internal repo enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cospectrum @johnhurt @drcaramelsyrup @eaufavor