mixedversion: introduce deployment modes #124405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit adds the notion of a "deployment mode" to mixedversion tests. Currently, we only define a `system-only` deployment mode, corresponding to the deployment performed on all mixedversion tests to date: cockroach is started without any tenants (virtual clusters), and client applications talk directly to the "system interface". This commit adds the functionality necessary for tests to be able to select what deployment modes make sense for them, if they verify something specific to some deployment mode. In the future, more deployment modes will be added: tenants in shared-process mode, and external process (serverless-style) tenants. Epic: none Release note: None
|
This change is |
renatolabs
force-pushed
the
rc/mixedversion-deployment-modes
branch
from
4662afe
to
629e407
Compare
renatolabs
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
DarrylWong
approved these changes
May 23, 2024
| @@ -441,7 +444,7 @@ func Test_stepSelectorFilter(t *testing.T) { | |||
| name: "no filter", | |||
| predicate: func(*singleStep) bool { return true }, | |||
| expectedAllSteps: true, | |||
| expectedRandomStepType: runHookStep{}, | |||
| expectedRandomStepType: restartWithNewBinaryStep{}, | |||
There was a problem hiding this comment.
It's rather subtle but prng determinism corresponds to both seed (which hasn't changed) and the number of calls to prng. The latter did indeed change; on L630, we've added a new call to prng.
srosenberg
approved these changes
May 23, 2024
|
TFTRs! bors r=herkolategan,DarrylWong,srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the notion of a "deployment mode" to mixedversion tests. Currently, we only define a
system-onlydeployment mode, corresponding to the deployment performed on all mixedversion tests to date: cockroach is started without any tenants (virtual clusters), and client applications talk directly to the "system interface". This commit adds the functionality necessary for tests to be able to select what deployment modes make sense for them, if they verify something specific to some deployment mode.In the future, more deployment modes will be added: tenants in shared-process mode, and external process (serverless-style) tenants.
Epic: none
Release note: None