Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add tunes data in mutation events #2686

Open
wants to merge 10 commits into
base: next
Choose a base branch
from

Conversation

GuillaumeOnepilot
Copy link
Contributor

My usage of EditorJs rely mainly on the Mutation events to make granular actions on my backend, instead of pushing the whole lists of blocks.

I'm currently working on an annotation feature which require the tunes data to be sent, but unfortunately the different events don't have the tunes data sent with them, which mean I have to change my logic (which would be complicated)

So I propose to add the tunes data inside the different mutations events.

@neSpecc
Copy link
Member

neSpecc commented Apr 15, 2024

I'm currently working on an annotation feature which require the tunes data to be sent

Could you provide some examples?

@GuillaumeOnepilot
Copy link
Contributor Author

So basically I want my tune to act a some kind of metadata on the blocks, but the events don't hold the tune's data and I don't use the saver api in my case.

Screen.Recording.2024-04-16.at.08.22.23.mov

@neSpecc
Copy link
Member

neSpecc commented Jun 8, 2024

Why not just call await event.detail.target.save()? Tunes data will be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants