Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level 4 (and clean some .env: calls and white spaces) #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lymkwi
Copy link
Contributor

@Lymkwi Lymkwi commented Jun 23, 2016

Two major issues come to my mind though :

  • The last quest (craft_ethanol) requires TenPlus1's farming_redo and will not work with vanilla's farming
  • There is no code (I think) removing fly and fast to people already on level 4. All players could be equal by still granting them on level 4, but we kept it as a reward for finishing the game.

@cornernote
Copy link
Owner

Hey @LeMagnesium,

Awesome! Thank you!

Are you able to add farming_redo to the depends file?

@Lymkwi
Copy link
Contributor Author

Lymkwi commented Jun 24, 2016

Are you able to add farming_redo to the depends file?

I think farming is already listed as a dependencie, but there is no way to determine that you are using farming redo instead of vanilla's version before loading the mod...
I could add an assertion, or a condition at the beginning of init.lua to block the mod from being loaded if there is no item registered with the name farming:corn.

@Panquesito7
Copy link
Contributor

@cornernote, may I re-make this PR? It's a good idea to implement this (also the #58 PR). Thanks. 🙂

@cornernote
Copy link
Owner

hey @Lymkwi , I can't auto merge this because it's got conflicts. If you re-make it I'll merge it in.

@Panquesito7
Copy link
Contributor

hey @Lymkwi , I can't auto merge this because it's got conflicts. If you re-make it I'll merge it in.

Also, see #58 (comment).

Panquesito7 added a commit to Panquesito7/minetest-skyblock that referenced this pull request Aug 1, 2021
Revival of cornernote#73 and cornernote#58.
Co-authored-by: Lymkwi <Lymkwi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants