updated types to bool in _turn_params_ to reflect C11 #1406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
approach was as follows, for the
_turn_params_
struct:int
orvint
was only being used as a boolean, replace it with bool as defined in<stdbool.h>
changes were only made when i was certain the variables were not being used as an
int
, so i may have missed someno changes were made to other sections of the code as int-to-bool assignment is allowed in C, only code within the structs were changed, but that can be changed with a later commit
from a documentation perspective, it's not clear as to what purpose or benefit the vint alias has. the definition in
ns_turn_defs.h
simply readswith no comments, and it seems most (but not all)
vint
s are being used as interim booleans through the code. this may just be from lack of knowledge of the codebase, but it doesn't seem useful in any way, so it would be helpful if someone with more expertise could clarify