💥 api: align Container.withNewFile signature with Directory.withNewFile
#7293
+446
−653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderco
force-pushed
the
helder/oss-202-signature-misalignment-of-directorywith_new_file-and
branch
4 times, most recently
from
9bfb361
to
8fcad31
Compare
|
The consistency argument is pretty compelling. If it was a good idea in |
shykes
approved these changes
May 24, 2024
helderco
force-pushed
the
helder/oss-202-signature-misalignment-of-directorywith_new_file-and
branch
from
8fcad31
to
f26353d
Compare
…ile` Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
helderco
force-pushed
the
helder/oss-202-signature-misalignment-of-directorywith_new_file-and
branch
from
f26353d
to
bf3e9f3
Compare
TomChv
reviewed
Jun 3, 2024
| * @param opts.permissions Permission given to the written file (e.g., 0600). | ||
| * @param opts.owner A user:group to set for the file. | ||
| * | ||
| * The user and group can either be an ID (1000:1000) or a name (foo:bar). | ||
| * | ||
| * If the group is omitted, it defaults to the same as the user. | ||
| */ | ||
| withNewFile = (path: string, opts?: ContainerWithNewFileOpts): Container => { |
There was a problem hiding this comment.
Yes I can confirm this is a breaking change for TypeScript.
The parameter contents moved from a struct param into a require unary parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a breaking change in Go and TypeScript1! 💥
Deprecation path not possible. May want to hold merge for v0.12.0.
Fixes #6961
Brings more consistency. We made
contentsmandatory inDirectory.withNewFilebut not inContainer.withNewFile:contentsmandatory #3911Footnotes
May need to double check on TS. Not a breaking change for Python. ↩