Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3595][Core] add ability to download files from daemon #443

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DjLegolas
Copy link
Contributor

When we use thin client mode, we will download tracker's icon from the client endpoint.
This means we are leaking the IP of the client location, instead using the daemon, which is already connected to the tracker. Therefor, an ability to download files from the daemon is added.

Closes https://dev.deluge-torrent.org/ticket/3595

When we use thin client mode, we will download tracker's icon from the
client endpoint.
This means we are leaking the IP of the client location, instead using
the daemon, which is already connected to the tracker.
Therefor, an ability to download files from the daemon is added.

Closes https://dev.deluge-torrent.org/ticket/3595
@DjLegolas
Copy link
Contributor Author

@cas-- as part of this fix, we need to change some (or even, all) of the calls to deluge.httpdownloader.download_file.
But, currently, I didn't managed to use client.core.download_file with callback param.
For example, it's being used in the add_from_url method in the GtkUI, when we show a progress bar for the download.

Do you think we need to support this functionality?
Or should we download files from the client? Which means an IP leak again.

@cas--
Copy link
Member

cas-- commented Mar 2, 2024

Hmm this is an interesting problem and you are likely correct with the long-term solution. However initially we will want to have an option to stop this happening client side 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants