Add color to hpa line when replicas >= maxpods #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurcgc
force-pushed
the
feat-hpa-colored
branch
from
38ef8ee
to
1f3eda6
Compare
arthurcgc
changed the title
derailed
requested changes
Dec 26, 2023
There was a problem hiding this comment.
@arthurcgc Thank you for this update Arthur! Just a few picks...
internal/render/hpa.go
Outdated
| return func(ns string, h Header, re RowEvent) tcell.Color { | ||
| c := DefaultColorer(ns, h, re) | ||
|
|
||
| maxPodsS := strings.TrimSpace(re.Row.Fields[h.IndexOf("MAXPODS", true)]) |
There was a problem hiding this comment.
We should validate IndexOf returns a valid index ie within the Fields range.
There was a problem hiding this comment.
hey @derailed, thanks for reviewing my PR. I'll make the changes!
There was a problem hiding this comment.
hey @derailed , could you take another look? Can I mark it as resolved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature described in this issue: #2279