Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds env in shellpod #2345

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wonko
Copy link

@wonko wonko commented Dec 14, 2023

Allows to define env vars for the shellpod container.

Closes #2244

  shellPod:
    image: busybox:1.35.0
    env:
    - name: HELLO
      value: world
    namespace: default

results in

<<K9s-Shell>> Pod: default/k9s-shell-3745 | Container: k9s-shell 
/ # set | grep HELLO
HELLO='world'
/ # 

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonko Thank you for this update Bernard!
We should update the docs as well to make sure users are aware.

@derailed derailed added the enhancement New feature or request label Dec 26, 2023
@wonko
Copy link
Author

wonko commented Jan 8, 2024

@wonko Thank you for this update Bernard! We should update the docs as well to make sure users are aware.

sure, if you can point me to where the docs are, i can try to update the content to include the env section on the shellpod

@derailed
Copy link
Owner

@wonko Thank you! Sure you can update the README.md for the time being. Also there are some conflicts ;(

@wonko
Copy link
Author

wonko commented Jan 11, 2024

@derailed updated the readme (and merged master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send env before shell in k9s
2 participants