2404: added update command #2412
Conversation
There was a problem hiding this comment.
@slimus First off, Thank you so much Alex for your good work on this!
This is a great convenience and something that has been requested in the past.
I think there are several ideas to explore here.
Dealing with users env is always dicey as we enter the I drather have X scene.
I'll propose we ship this as such with a few TLCs at first, gather users feedback and then rinse/repeat on enhancements.
I think minimally we could put some lipstick on it and offer just an upgrade functionality to the latest rev.
We do need to decide at this juncture our upgrade/downgrade strategy ie hard download or download+symlink or ??
|
|
||
| func selfUpdate() *cobra.Command { | ||
| command := cobra.Command{ | ||
| Use: "selfupdate", |
There was a problem hiding this comment.
To me selfUpdate has the connotation of updating while the app is running.
Perhaps update or upgrade might be more appropriate?
Also what should happen if a user has current k9s session(s) up and running while updating the binary?
There was a problem hiding this comment.
Soooo, this is where holywar starts :):
- Homebrew uses
updatecommand to update brew, andupgradeto update packages. - Composer uses
self-update - Helm doesn't have selfupdate command, but they use
upgradecli to update helm releases. - Pip uses
pip install --upgrade pipto update pip itself. - ....
So, this is really hard to pick one command, but at the same time - I don't want to have multiple commands to achieve only one simple result :)
I'm okay to change this command to update.
| Use: "selfupdate", | ||
| Short: "Update k9s binary", | ||
| Long: "Update k9s binary", | ||
| Run: func(cmd *cobra.Command, args []string) { |
There was a problem hiding this comment.
I think we should define additional flags here:
- The default aka upgrade to the latest rev
- Update to a given version
- List the last x releases and dates
- Rollback to previous (default) or given version
Perhaps leveraging symlinks here could be interesting?? ie keep the last x on disk and just swap the link if present??
Given my release track record that could be handy... ;)
In this case we could offer a purge option to axe previous revs?
There was a problem hiding this comment.
This is great improvements. I forgot about rollbacks at all! I will add these options.
| } | ||
|
|
||
| if latest.LessOrEqual(version) { | ||
| log.Info().Msgf("Current version (%s) is the latest", version) |
There was a problem hiding this comment.
Likely users of this command won't be looking at logs. Best to output the results to the console stdout or stderr.
Also thinking it might be good idea to match other k9s command look and feel ie banner + colorized output.
BONUS: leverage a progress bar (https://github.com/schollz/progressbar) or other to provide feedback
There was a problem hiding this comment.
Great catch! Yes, I'll change it to use stdout instead of logs and try to add progressbar :)
| } | ||
|
|
||
| func updateApp(latest *selfupdate.Release) error { | ||
| exe, err := os.Executable() |
There was a problem hiding this comment.
What if this is a link?
Also what if this process borks and we leave things in no mans land?
Perhaps best to download the requested rev in a tmp location and if we are cool size/checksum move to the final resting place ie real or link?
Also not sure if we get this for free or not but we should validate checksum to make sure we got real mcCoy?
There was a problem hiding this comment.
That's why I asked to help me to test all scenarios. I'll test links and let you know later.
About checksums - selfupdate library should check sums, but again, I'll test it and let you know later.
Added command to update binary.
Need some help to test it with different operation systems