Block size validation in compact blocks #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Dagur Johannsson <dagurval@pvv.ntnu.no>
Unit tests for GetNextMaxBlockSize and FindVote. Multi-node voting regression test. With Tom Harding <tomh@thinlink.com> Includes regtest routines by Gavin Andresen <gavinandresen@gmail.com>
If exception occurrs, request full block instead of processing the compact block.
Max sigops calculation changed to use actual block size rather than hardLimit
This adds BIP100 votes to blocks generated by miner software that uses the rpc call getblocktemplate.
Add BIP100 string to getblocktemplate
This reverts commit b7e1ef3.
Makes validation compatible with BIP100.
dgenr8
force-pushed
the
bip100
branch
2 times, most recently
from
5d942e6
to
e13cc7d
Compare
|
Cherry-picked to main repo bitcoinxt#188 to avoid rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be made much simpler since there is a 5% cap