Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #35074 -- Simplified adding spatial indexes on MySQL and Oracle. #18175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented May 17, 2024

This uses deferred_sql and _field_indexes_sql() instead of custom hooks on MySQL. It's a preparation for ticket-35074.

@felixxm felixxm force-pushed the issue-35074-test-2 branch 7 times, most recently from 5caece4 to fb549c8 Compare May 19, 2024 12:34
@felixxm felixxm changed the title Refs #35074 -- Simplified adding spatial indexes on MySQL. Refs #35074 -- Simplified adding spatial indexes on MySQL, SpatiaLite, and Oracle. May 19, 2024
… and Oracle.

This uses `deferred_sql` and `_field_indexes_sql()` instead of custom
hooks on MySQL.
@felixxm felixxm changed the title Refs #35074 -- Simplified adding spatial indexes on MySQL, SpatiaLite, and Oracle. Refs #35074 -- Simplified adding spatial indexes on MySQL and Oracle. May 19, 2024
@felixxm
Copy link
Member Author

felixxm commented May 19, 2024

Unfortunately, we cannot do the same for SpatiaLite due to the way how table remake works.

@felixxm
Copy link
Member Author

felixxm commented May 19, 2024

buildbot, test on oracle.

@nessita
Copy link
Contributor

nessita commented May 31, 2024

Thank you @felixxm for this work!

@smithdc1 @claudep Is this something that (any of) you could help me test?

/remind me to re-review this in 20 days

Copy link

@nessita set a reminder for 6/20/2024

@claudep
Copy link
Member

claudep commented May 31, 2024

Sorry, I'm out of the game for anything related to Oracle (or any other proprietary software).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants