Allow CPU to bridge over water when not wall hugging #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to run `find_from_task_list` before queueing a bridge, because this is the imp's task list, and bridging is not an imp task so won't be listed. When handling water slabs, we want to leave `tool_dig_to_pos2_skip_slabs_which_dont_need_digging_f` when we have bridges available, otherwise we want to treat the water as passable. When handling lava slabs, we want to leave `tool_dig_to_pos2_skip_slabs_which_dont_need_digging_f` always, because we either want to bridge it, or it is impassable and should be wallhugged.
|
This is the situation in master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU will actually bridge over water in master, but only when the "mark for digging" routine is in wallhug mode.
This PR should make the CPU be able to bridge over water in the same way as it bridges over lava if bridges are available.
If bridges aren't available the water will be treated as "passable".
We do not want to run
find_from_task_listbefore queueing a bridge, because this is the imp's task list, and bridging is not an imp task so won't be listed.When handling water slabs, we want to leave
tool_dig_to_pos2_skip_slabs_which_dont_need_digging_fwhen we have bridges available, otherwise we want to treat the water as passable.When handling lava slabs, we want to leave
tool_dig_to_pos2_skip_slabs_which_dont_need_digging_falways, because we either want to bridge it, or it is impassable and should be wallhugged.