Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External speeches for Adam #2910

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

External speeches for Adam #2910

wants to merge 12 commits into from

Conversation

Loobinex
Copy link
Member

@Loobinex Loobinex commented Dec 29, 2023

Also, volume is set when it is played. Before it was determined when the script was loaded.

@Loobinex Loobinex marked this pull request as ready for review December 29, 2023 13:57
@AdamPlenty
Copy link
Contributor

Will this affect non-speech external sounds?

@Loobinex
Copy link
Member Author

Will this affect non-speech external sounds?

I did 2 fixes:

  • SPEECH should now play with the speech volume, not the sound volume. So only changes speeches
  • All external sounds now have the volume set once they are played, not once the script is loaded. This affects all external sounds yes.

@AdamPlenty
Copy link
Contributor

AdamPlenty commented Dec 30, 2023

for (int i = 0; i < EXTERNAL_SOUNDS_COUNT; i++)

Is this still needed?

Edit: It also looks like it changes all external sounds.

Edit 2: It actually is needed (and needs to be fixed) if we want speeches to change volume immediately. Unfortunately, I don't think we record whether it's a sound or a speech anywhere...

@Loobinex Loobinex changed the title External speeches played using mentor volume External speeches for Adam Jan 2, 2024
@Loobinex Loobinex marked this pull request as draft January 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants