New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External speeches for Adam #2910
base: master
Are you sure you want to change the base?
Conversation
Will this affect non-speech external sounds? |
I did 2 fixes:
|
keeperfx/src/frontmenu_options.c Line 319 in 214ee4d
Is this still needed? Edit: It also looks like it changes all external sounds. Edit 2: It actually is needed (and needs to be fixed) if we want speeches to change volume immediately. Unfortunately, I don't think we record whether it's a sound or a speech anywhere... |
This reverts commit 92be212.
Also, volume is set when it is played. Before it was determined when the script was loaded.