New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creatures leave dungeon if you lose level via the LOSE_GAME script co… #3005
base: master
Are you sure you want to change the base?
Conversation
Can this be somehow configurable? I kinda like the current behavior. 🤔 |
I dunno 🤔. The important thing is that it's consistent with the behaviour of creatures coming out of being possessed as a result of losing, which is now that they leave. Creatures left in the original game, too. |
Yeah ok, don't bother then. 👍 Consistency is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is nice and elegant, but unfortunately it does not work for me.
Regular creatures are handled, but imps do not die on LOSE_GAME, like they do on destroyed hearts.
Imps just carry on with their work in vanilla. Is this a bug? |
O, I did not know this. Have no idea when or why did change for FX. |
I definitely remember Imps dying on heart destruction, but if you lose via the script, they just carry on as if nothing happened, even though your creatures leave or die. |
ok, well, if you're going for consistently between heart destruction and losing, this is something to make consistent then right? |
Do they need to be consistent, though? Do Imps die because you've lost the level in itself, or because your Dungeon Heart has been destroyed? |
Whatever the answer is to this question, do you not think this is the same answer as to the question "Do creatures leave/die because you've lost the level in itself, or because your Dungeon Heart has been destroyed?" |
Imps are magical beings, summoned (and presumably sustained) by magic. If you lose via the script, your Dungeon Heart still exists. Creatures are different; they no longer have a master to serve, even if you lose via the script. |
With your change creatures spontaneously die when you 'lose game' and they cannot get to a portal. For me this really seems like doing it halfway, and I am seeing really two valid options:
If we are disagreeing on this, we'll need some extra opinions. |
…mmand