More flags on instances to allow more freedom on which instance cast under certains conditions #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename CAST_ON_CUSTODY into WHILE_IMPRISONED + add a check so they don't cast buff if already buffed.
Changed idling and working to have distinction between creatures and heroes for instances cast outside of battle
self_buff comment + give it to Wind
kept the new enum but reverted to use a number for func_idw check because it doesn't build and I don't know why
|
Tried to move stuff to the header but it didn't work either so for now back to using a number for func_idx check because of build warnings/errors that I can't figure why it happens 🥲. If someone know why and know how to fix, please go ahead and fix it, if you want of course, thanks! |
This reverts commit 91be4ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new properties for instance on creature.cfg:OUT_OF_BATTLE allows instance to be used whenever available when the creature is not fighting and not imprisoned.WHILE_IMPRISONED allows instance to be used whenever available when the creature is imprisoned.EDIT: it now adds a whole bunch of Activation Flag instead. See comments on creature.cfg.