Max fighters #3148
Draft
Max fighters #3148
+37
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loobinex
reviewed
Apr 15, 2024
src/config_rules.c
Outdated
| @@ -117,6 +117,8 @@ const struct NamedField rules_creatures_named_fields[] = { | |||
| {"GAMETURNSUNCONSCIOUS", &game.conf.rules.creature.game_turns_unconscious,var_type(game.conf.rules.creature.game_turns_unconscious), 0,USHRT_MAX}, | |||
| {"STUNEVILENEMYCHANCE", &game.conf.rules.creature.stun_enemy_chance_evil,var_type(game.conf.rules.creature.stun_enemy_chance_evil), 0, 100}, | |||
| {"STUNGOODENEMYCHANCE", &game.conf.rules.creature.stun_enemy_chance_good,var_type(game.conf.rules.creature.stun_enemy_chance_good), 0, 100}, | |||
| {"MaxMeeleOpponents", &game.conf.rules.creature.stun_enemy_chance_good,var_type(game.conf.rules.creature.stun_enemy_chance_good), 0, COMBAT_MELEE_OPPONENTS_LIMIT}, | |||
walt253
reviewed
Apr 16, 2024
| @@ -1490,7 +1490,7 @@ CrAttackType check_for_possible_melee_combat_with_attacker_within_distance(struc | |||
| struct CreatureControl* figctrl = creature_control_get_from_thing(fightng); | |||
There was a problem hiding this comment.
I'm not 100% certain but check those lines 1455 / 1460 / 1464 / 1471 / 1476 / 1480.
I think the magic number 4 refer to the limit that is hardcoded, so maybe it should no longer be 4 but the actual limit set in config now?
score_base = 258 * (4 - enmctrl->opponents_ranged_count) + score_extra;
would become:
score_base = 258 * (COMBAT_RANGED_OPPONENTS_LIMIT - enmctrl->opponents_ranged_count) + score_extra;
if that makes senses to you? 🤔
There was a problem hiding this comment.
aight makes sense, I'll try and figure out all of the magic numbers in the function, but those 4's being the max opponents makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.