Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make powerhand light configurable by gamerule #3179

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PieterVdc
Copy link
Member

No description provided.

config/fxdata/rules.cfg Outdated Show resolved Hide resolved
Copy link
Member

@Loobinex Loobinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The light radius in all other places multiplies the config value by 256, so it would just be '10' here. See the LightRadius in objects.cfg or in trapdoor.cfg

config/fxdata/rules.cfg Show resolved Hide resolved
@@ -723,7 +723,7 @@ void init_player_as_single_keeper(struct PlayerInfo *player)
struct InitLight ilght;
memset(&ilght, 0, sizeof(struct InitLight));
player->field_4CD = 0;
ilght.radius = game.conf.rules.game.hand_light_radius;
ilght.radius = game.conf.rules.game.hand_light_radius * COORD_PER_STL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to do it where we configure it like here?
b36b3ef#diff-1bf5b73865ef053252f6a94089db492d69cd359a860427bbcd544209df9166d7R190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants