Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mate #2532

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mate #2532

wants to merge 4 commits into from

Conversation

zxvv
Copy link
Contributor

@zxvv zxvv commented Apr 15, 2016

this adds the target 'mate' consisting of the mate-desktop-environment package, available on most ubuntu releases, and debian jessie and newer.

@zxvv
Copy link
Contributor Author

zxvv commented Apr 15, 2016

One can start mate natively using:
startmate

Or, one can start mate in xiwi using:
sudo startxiwi -F mate-session

However, when using xiwi, some desktop items display error dialogs due to differences from mate's 'marco' window manager.

This is not an issue when it is started natively using 'startmate'.

@zxvv
Copy link
Contributor Author

zxvv commented Apr 16, 2016

This addresses the request for a mate target: #2520

@JaxonWright
Copy link

Thanks for this. Hopefully it gets added soon!

CHROOTBIN='crouton-noroot startmate'
. "${TARGETSDIR:="$PWD"}/common"

if release -lt jessie ; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check should be done prior to installation, like in the e17 target. It looks like you might also need a check for ARM + PPA?

@dnschneid
Copy link
Owner

Thanks again. Similar to the LXQT addition, if all the supported releases (wheezy jessie stretch sid kali-rolling precise trusty) and arches (i386, x86_64, arm) aren't covered, there needs to be tests prior to installation. You already have some of the tests, but please make sure everything is there.

@zxvv
Copy link
Contributor Author

zxvv commented Apr 30, 2016

I've added the checks, prior to install, for unsupported arch (arm) and unsupported releases.

I tried and failed to squash. I'll try to resolve that.

@zxvv
Copy link
Contributor Author

zxvv commented May 1, 2016

OK, I believe I've squashed the commits into a single commit.
Please let me know if there's anything else that needs attention!


if [ "${TARGETNOINSTALL:-c}" = 'c' ]
if [ "${ARCH#arm}" != "$ARCH" ]; then
error 99 "Mate packages are not available for ARM."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, sorry, I should have realized earlier that Mate isn't available for ARM.
Historically I haven't merged DEs unless they're available on a vast majority of Chromebooks (there's quite a lot of ARM) and on a majority of the supported releases.

I think Mate now squeaks by on the latter point, but I'm extremely hesitant to include something that only works on certain architectures.

@drinkcat @DennisLfromGA thoughts?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is Mate available on ARM on later releases?

@zxvv
Copy link
Contributor Author

zxvv commented May 2, 2016

It's available on arm64 but not arm. The same is true for lxqt, and certain others.

But "${ARCH#arm}" != "$ARCH" was wrong.
I changed it to "${ARCH}" = "arm" so that it excludes install only on arm
and will install on arm64.

As an aside, there are a few others targets such as chromium are available on arm64 in debian jessie and stretch. It might be worth considering installing on arm64 for those.

allow install on ARM.
@zxvv
Copy link
Contributor Author

zxvv commented May 5, 2016

I reread the xfce4 target, and see that xfce4 is available for arm64, armel and armhf, and lxde, lxqt and mate are available for the same -- arm64, armel and armhf.

So, the above commit removes the code that excludes the ARM target.
it installs on ARM now. (I discussed this in the LXQT PR as well).

# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

if [ "${TARGETNOINSTALL:-c}" = 'c' ]
Copy link

@Morgul Morgul May 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then (bash complains about an unmatched fi otherwise.)

@zxvv zxvv force-pushed the mate branch 2 times, most recently from 6f99696 to a3a39e8 Compare May 18, 2016 02:41
@zxvv
Copy link
Contributor Author

zxvv commented May 18, 2016

On xenial, the ppa:ubuntu-mate-dev/xenial-mate repo is added, and
the caja-actions ubuntu-mate-artwork that it provides are installed.

Thanks for the help. Please let me know if there are remaining issues.


if release -le precise ; then
install software-properties-common
sudo apt-add-repository -y "deb http://packages.mate-desktop.org/repo/ubuntu precise main"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is already run as root, so sudo isn't necessary anywhere in here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with arm on precise?

@dnschneid
Copy link
Owner

Sorry for the long delay in replying!

@zxvv
Copy link
Contributor Author

zxvv commented Jun 9, 2016

There are arm binaryies for trusty:
http://ppa.launchpad.net/ubuntu-mate-dev/trusty-mate/ubuntu/dists/trusty/main/
So yes, it needed to be changed.

On trusty, it allows install on arm now.
If/when you want the commits squashed just let me know!

@dnschneid
Copy link
Owner

I ran this and #2525 through the autotester, and both had lots of problems across different releases.

Here's the test output. If you extract it somewhere and open status.html, you'll see a bunch of red logs, which you can open up and look for more details as to what failed.

trusty, for example, seems to be missing /usr/bin/mate-session.

@JaxonWright
Copy link

Any progress on this? I would love a simple way to get Mate

@farinc
Copy link

farinc commented Apr 28, 2017

I know this is old, but there any more progress on this? Like @JaxonWright, I would love Mate in my chroot.

@carbonatedcaffeine
Copy link

really all it needs is
mate
mate-extra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants