Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Warning Logging and Integrate with Visual Studio Test Logging #2572

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

sheffer21
Copy link
Contributor

This pull request adds support for warning logging and integrates this new functionality with the Visual Studio test logging framework.

@sheffer21
Copy link
Contributor Author

@dotnet-policy-service agree

@adamsitnik
Copy link
Member

@caaavik-msft PTAL

Copy link
Contributor

@caaavik-msft caaavik-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheffer21
Copy link
Contributor Author

@adamsitnik could you please review this PR? Thanks!

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if any of our non-critical validators should use the new warning level.

@timcassell timcassell merged commit 6a7244d into dotnet:master Jun 1, 2024
8 checks passed
@timcassell timcassell added this to the v0.14.0 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants