-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix primary assembly heuristic + clean up duplicate code #17151
Conversation
|
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
Also a note - we spend quite some time generating PDB in all scenarios, even though it will never be used. Around 1/3rd of total assembly generation time, for example on my M2 it takes 50ms to generate metadata and additional 24ms to generate pdb. |
Should we create an issue about it to keep track? |
I did already. Not sure why it didn't link it here. Nvm, it did: #17152 |
Description
This fixes primary assembly check by:
Compare <> 0 || ...
now its justEquals ||
, which will exit on the first match, as opposed to checking everything.It also gets rid of specific cache for int32 in the ilreader, as well as hides stats under define.
FSI startup is a bit faster on M2, should be more noticeable on older/slower machines:
Before:
After:
Before: dotnet_trace_before.speedscope.json
After: dotnet_trace_after.speedscope.json