Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Use asset details flyout overview and metadata for containers #183767

Conversation

jennypavlova
Copy link
Contributor

Closes #183727

Summary

This PR adds asset details flyout to the inventory containers view. The feature flag observability:enableInfrastructureContainerAssetView should be enabled to see it.
To handle the asset type switching in the asset details flyout this PR adds asset type to the assetDetailsFlyout URL param

Before:
image

After:

  • Overview
    image
  • Metadata
    image

Testing

  • Enable observability:enableInfrastructureContainerAssetView in infra settings
  • Go to containers view, click on a container, and check the content
container_flyout.mov

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 17, 2024
@jennypavlova jennypavlova self-assigned this May 17, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova changed the title infra use asset details flyout overview and metadata fo containers [Infra] Use asset details flyout overview and metadata for containers May 17, 2024
@jennypavlova jennypavlova marked this pull request as ready for review May 17, 2024 16:56
@jennypavlova jennypavlova requested a review from a team as a code owner May 17, 2024 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennypavlova for doing this, LGTM
I'm wondering if there are tests for the flyout that we need to add or modify for the container

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 20, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 21, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +681.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5410 +5410
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova
Copy link
Contributor Author

jennypavlova commented May 21, 2024

@MiriamAparicio Thank you for reviewing the PR!

I'm wondering if there are tests for the flyout that we need to add or modify for the container

Good point, I am afraid we don't have tests for the container flyout. I will add a task for it and start adding some after we merge this PR.
Edit

@jennypavlova jennypavlova merged commit df74eb6 into elastic:main May 21, 2024
31 checks passed
@jennypavlova jennypavlova deleted the 183727-infra-use-asset-details-flyout-overview-and-metadata-fo-containers branch May 21, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Use asset details flyout (overview and metadata) fo containers
6 participants