-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Use asset details flyout overview and metadata for containers #183767
[Infra] Use asset details flyout overview and metadata for containers #183767
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…ew-and-metadata-fo-containers
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jennypavlova for doing this, LGTM
I'm wondering if there are tests for the flyout that we need to add or modify for the container
…ew-and-metadata-fo-containers
💚 Build Succeeded
Metrics [docs]Async chunks
Canvas Sharable Runtime
HistoryTo update your PR or re-run it, just comment with: |
@MiriamAparicio Thank you for reviewing the PR!
Good point, I am afraid we don't have tests for the container flyout. I will add a task for it and start adding some after we merge this PR.
|
Closes #183727
Summary
This PR adds asset details flyout to the inventory containers view. The feature flag
observability:enableInfrastructureContainerAssetView
should be enabled to see it.To handle the asset type switching in the asset details flyout this PR adds asset type to the
assetDetailsFlyout
URL paramBefore:
After:
Testing
observability:enableInfrastructureContainerAssetView
in infra settingscontainer_flyout.mov