Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables] Fix missing panel references when Duplicate, Copy to Dashboard, or Save as new dashboard #183778

Merged
merged 18 commits into from
Jun 4, 2024
Merged

[Embeddables] Fix missing panel references when Duplicate, Copy to Dashboard, or Save as new dashboard #183778

merged 18 commits into from
Jun 4, 2024

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented May 17, 2024 •
edited

Fixes #183551

Summary

Fixes missing references on React embeddables when Duplicate, Copy to Dashboard, or Save as new dashboard.

To test this:

  1. Start Kibana with yarn start --run-examples.
  2. Install at least two sample datasets.
  3. Create a new dashboard and add a Field list panel.
  4. Change the data view in the Field list panel to something other than the default data view.
  5. Duplicate the panel and ensure the data view does not revert to the default.
  6. Copy the panel to a new or existing dashboard and ensure the data view does not revert.
  7. Save the dashboard to a new dashboard and ensure the data view does not revert.

@nickpeihl nickpeihl changed the title [Embeddables] Fix duplicate panel react embeddable [Embeddables] Fix missing panel references when Duplicate, Copy to Dashboard, or Save as new dashboard May 24, 2024
@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl
Copy link
Member Author

/ci

@nickpeihl nickpeihl added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.15.0 labels May 24, 2024
@nickpeihl nickpeihl marked this pull request as ready for review May 24, 2024 23:41
@nickpeihl nickpeihl requested a review from a team as a code owner May 24, 2024 23:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl marked this pull request as draft May 24, 2024 23:45
@nickpeihl nickpeihl marked this pull request as ready for review May 29, 2024 16:31
@nickpeihl
Copy link
Member Author

/ci

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label May 31, 2024
@ThomThomson
Copy link
Contributor

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor

@elasticmachine merge upstream

@ThomThomson ThomThomson self-requested a review June 4, 2024 17:42
ThomThomson
ThomThomson approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Tested cloning, copy to dashboard, and duplicating Dashboards, checking the references each time in the saved object management page. code changes look well targeted also. Nice work!

While testing this I did notice an infinite load bug in the field list embeddable when a Dashboard has field lists with two different data views, but was able to confirm that this happens in main also.

Thanks for making the change regarding using serialized state rather than runtime state for these operations.

@ThomThomson ThomThomson merged commit d0383b4 into elastic:main Jun 4, 2024
5 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 4, 2024
@ThomThomson ThomThomson mentioned this pull request Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Embeddables] Duplicate, Copy to dashboard, and Save as new dashboard actions do not include references
4 participants
@nickpeihl @elasticmachine @ThomThomson @kibanamachine