Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric Viewer in Dashboard: ensure report displays chart for SMV panel in pdf/png #183780

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented May 17, 2024

Summary

This PR fixes #183448 for 8.14
As the code has been updated in latest main - there will be a separate fix PR for 8.15

This PR passes the onRenderComplete callback to the single metric viewer component and calls it when it is done loading internally. This should keep the dashboard up to date on the status of the panel for export.

Confirmed the pdf/png are showing the SMV embeddable correctly now.

image image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this May 17, 2024
@alvarezmelissa87 alvarezmelissa87 added the ci:cloud-deploy Create or update a Cloud deployment label May 20, 2024
@alvarezmelissa87 alvarezmelissa87 marked this pull request as ready for review May 20, 2024 14:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 20, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.1MB 4.1MB +49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87
Copy link
Contributor Author

cc @bhavyarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment Feature:Anomaly Detection ML anomaly detection Feature:Embeddables Relating to the Embeddable system :ml release_note:fix v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants