Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs Applications > Services][KEYBOARD]: "What are these metrics?" tooltip icon must receive keyboard focus #183808

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 20, 2024

Closes: https://github.com/elastic/observability-dev/issues/3402

Description

The Obs Applications > Services view has a "What are these metrics?" icon that exposes a tooltip when hovered, but that tooltip cannot take keyboard focus, making it unavailable to keyboard users. Screenshot attached below.

Steps to recreate

  1. Open the Obs Services view
  2. Tab through the table, until focus is on an element after the "What are these metrics" question mark icon
  3. Verify the icons in the table row(s) never receive focus and the tooltips never become visible

What was changed?:

  1. EuiToolTip -> EuiIconTip

Screen:

Screen.Recording.2024-05-20.at.12.16.37.mov

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.15.0 Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels May 20, 2024
@alexwizp alexwizp marked this pull request as ready for review May 20, 2024 09:17
@alexwizp alexwizp requested a review from a team as a code owner May 20, 2024 09:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith removed the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label May 20, 2024
@alexwizp alexwizp added the backport:skip This commit does not require backporting label May 21, 2024
@alexwizp alexwizp removed the ci:project-deploy-observability Create an Observability project label Jun 3, 2024
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 6, 2024
@alexwizp alexwizp enabled auto-merge (squash) June 10, 2024 12:56
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 10, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -31.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 5a9bfd0 into elastic:main Jun 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants