-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Obs Applications > Services][KEYBOARD]: Environment badges must show tooltips on keyboard focus as well as mouse hover #183809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show tooltips on keyboard focus as well as mouse hover Closes: elastic/observability-dev#3403
/ci |
alexwizp
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.15.0
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
Project:Accessibility
labels
May 20, 2024
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Pinging @elastic/unified-observability (Team:Observability) |
smith
added
the
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
label
May 20, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
smith
added
apm:review
and removed
Team:Observability
Team label for Observability Team (for things that are handled across all of observability)
labels
May 20, 2024
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
May 22, 2024
alexwizp
removed
the
ci:project-deploy-observability
Create an Observability project
label
Jun 3, 2024
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Jun 6, 2024
justinkambic
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:review
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
Project:Accessibility
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-dev/issues/3403
Description
The Obs Applications > Services table rows have an
Environment
badge that exposes a tooltip when hovered, but that tooltip cannot take keyboard focus, making it unavailable to keyboard users. Screenshot attached below.Steps to recreate
Environment
badgeWhat was changed?:
Screen:
Screen.Recording.2024-05-20.at.12.34.31.mov