Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [date-picker] model-value unexpected changes when type is week #16795

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(components): [date-picker] model-value unexpected changes when type is week #16795

wants to merge 2 commits into from

Conversation

FrontEndDog
Copy link
Member

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fixed #16792

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16795
Please comment the example via this playground if needed.

@zhouxianjun
Copy link

@btea 大佬，这个可以review一下吗？

btea
btea approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't understand why the deleted code was added. However, it does solve the problem. Maybe it needs to be reviewed by others.

@btea btea requested a review from kooriookami May 31, 2024 01:20
@kooriookami
Copy link
Member

当没有选择最终值的时候，也就是面板没有关闭，value还是改变了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@kooriookami kooriookami Awaiting requested review from kooriookami

Assignees

@FrontEndDog FrontEndDog

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
4 participants
@FrontEndDog @zhouxianjun @kooriookami @btea