Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [color-picker] attrs class #16887

Merged
merged 2 commits into from
May 25, 2024
Merged

fix(components): [color-picker] attrs class #16887

merged 2 commits into from
May 25, 2024

Conversation

Liao-js
Copy link
Contributor

@Liao-js Liao-js commented May 16, 2024 •
edited

fix #16886

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @Liao-js, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @Liao-js, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16887
Please comment the example via this playground if needed.

btea
btea approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btea btea merged commit a8d2a5f into element-plus:dev May 25, 2024
9 checks passed
@element-bot element-bot mentioned this pull request May 31, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@Liao-js Liao-js

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [color-picker] Cannot set class name of el-color-picker’s trigger
2 participants
@Liao-js @btea