Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): [form] remove unused ref #16888

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

lkdhy
Copy link
Contributor

@lkdhy lkdhy commented May 16, 2024

<el-form
ref="form"
style="max-width: 600px"
:model="sizeForm"
label-width="auto"
:label-position="labelPosition"
:size="size"

这里 ref="form" 的 form 原来没定义

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

<el-form
    ref="form"
    style="max-width: 600px"
    :model="sizeForm"
    label-width="auto"
    :label-position="labelPosition"
    :size="size"
  >
这里 ref="form" 的 form 原来没定义
Copy link

👋 @lkdhy, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Copy link

Hello @lkdhy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@btea
Copy link
Collaborator

btea commented May 17, 2024

你好,谢谢你的贡献!这里似乎没有直接用到 el-form 组件的引用,可以直接把 ref="form" 删掉。

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 20, 2024
@btea btea changed the title 增加和 ref="form" 对应的 form docs(components): [form] remove unnecessary ref May 20, 2024
@plainheart plainheart changed the title docs(components): [form] remove unnecessary ref docs(examples): [form] remove unused ref May 20, 2024
@plainheart plainheart merged commit 63ec01e into element-plus:dev May 20, 2024
9 checks passed
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16888
Please comment the example via this playground if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants