TerminalWidget: Port Context Menu to GLib.MenuModel and Gtk.PopoverMenu #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How near are we to switching to Gtk4? Would it be better to leave this until switch is imminent so degradation of UI is minimised? |
We don't have the Gtk4 version of VTE in jammy, so it would need to wait for once we are "done" with releases for OS 7.
I'm fine in waiting for it, this part of code won't have much changes, if any, until there. |
jeremypw
added
the
Status: Blocked
|
Adding blocked label - waiting for Gtk4 version of Vte. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to Gtk4. The changing from Gtk.Menu to Gtk.PopoverMenu happens because Gtk.Menu will inherit the monospace font from the TerminalWidget, sadly, it requires that we lost the accels in the menu for now.